src: implement standard.js linting #1794
Merged
+746
−668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
approved these changes
Jun 24, 2019
|
I've no real preferences re. Since we have Travis enabled now and the linting is run as part of the |
bnoordhuis
approved these changes
Jun 27, 2019
rvagg
force-pushed
the
rvagg/standard
branch
4 times, most recently
from
ce9d0b4 to
e9fefd9
Compare
|
implemented 'use strict' and a couple of other minor tweaks including making consistent spacing with array declarations |
joaocgreis
approved these changes
Jul 4, 2019
In addition:
* moved module.exports to the bottom
* no single-line if statements
* no if statements without a {
* const for requires
* array declarations get spaces inside [ ]
* 'use strict' in all .js files
PR-URL: #1794
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: João Reis <[email protected]>
|
@rvagg it would be good to get this one landed to avoid it becoming outdated. AFAICT this is ready to land and I can do it tomorrow, please let me know if I shouldn't. |
4 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO it's time for some proper linting, the code style is all over the place and the existing rules were super minimal. Current style is pretty close to standard.js, and it's a fairly universally accepted and understood style.
I've done a couple of additional things on top:
module.exportsto the bottomifstatementsifstatements without a{constfor requiresThis is going to make it harder to manage older pull requests of course, so this comes with a cost.
Thoughts?